Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3570#issuecomment-66346390
This looks good to me. If you don't mind, could you update the pull
request description to more accurately describe the change that we're actually
committing? This is important because that description will become the actual
commit message.
Also, it looks like the MiMa issue could have been caused by `private
object` maybe having different semantics that we expected; we ran into a
similar issue over at #3622.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
