Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3574#discussion_r21491375 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1010,7 +1010,10 @@ private[spark] class BlockManager( info.synchronized { // required ? As of now, this will be invoked only for blocks which are ready --- End diff -- This comment actually refers to the `!info.waitForReady()` case, so I'd like to either move the comment or swap the order of these checks so that we check for `blockInfo.get(blockId).isEmpty` in the `else if` clause instead.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org