Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3603#discussion_r21582546 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/feature/IDFSuite.scala --- @@ -86,6 +101,19 @@ class IDFSuite extends FunSuite with MLlibTestSparkContext { val tfidf2 = tfidf(2L).asInstanceOf[SparseVector] assert(tfidf2.indices === Array(1)) assert(tfidf2.values(0) ~== (1.0 * expected(1)) absTol 1e-12) + + // Transforms local vectors --- End diff -- Same here (putting the checks in a helper method to eliminate duplicated code)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org