Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3603#discussion_r21582550
--- Diff: python/pyspark/mllib/feature.py ---
@@ -212,7 +212,7 @@ class IDFModel(JavaVectorTransformer):
"""
Represents an IDF model that can transform term frequency vectors.
"""
- def transform(self, dataset):
+ def transform(self, data):
--- End diff --
This is a public API change, so it's a bit worrisome. On the other hand,
it makes sense to change it if this method includes single-vector transforms
too. @mengxr Opinion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
