Github user akopich commented on the pull request: https://github.com/apache/spark/pull/1269#issuecomment-67399691 @jkbradley Thank you for explanation about setters. tm implementation was tested (it was succesfully used in one of my project) but it was tested with scala 2.11, not scala 2.10. Is it necessary to implement this test as a part of spark project? I suggest the following: I just write an example running PLSA training (distributed one) on a particular dataset and add it to this patch. Also I write an example running PLSA training reliying on tm project and add it to tm project. One can ran both of these examples and ensure that perplexity values look similar. What do you think?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org