Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3824#discussion_r22323517
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -719,26 +719,28 @@ private[spark] class Master(
def rebuildSparkUI(app: ApplicationInfo): Boolean = {
val appName = app.desc.name
val notFoundBasePath = HistoryServer.UI_PATH_PREFIX + "/not-found"
- val eventLogFile = app.desc.eventLogDir
- .map { dir => EventLoggingListener.getLogPath(dir, app.id) }
- .getOrElse {
- // Event logging is not enabled for this application
- app.desc.appUiUrl = notFoundBasePath
- return false
- }
- val fs = Utils.getHadoopFileSystem(eventLogFile, hadoopConf)
+ var eventLogFile: String = null
--- End diff --
It looks like `eventLogFile` is only read from inside the `try` block on
the following line, so why not move it inside and make it into a `val` instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
