Github user WangTaoTheTonic commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3841#discussion_r22372988
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -176,6 +176,10 @@ class SparkContext(config: SparkConf) extends Logging 
with ExecutorAllocationCli
       logInfo(s"Running Spark version $SPARK_VERSION")
       
       private[spark] val conf = config.clone()
    +  val portRetriesConf = conf.getOption("spark.port.maxRetries")
    +  if (portRetriesConf.isDefined) {
    +    System.setProperty("spark.port.maxRetries", portRetriesConf.get)
    --- End diff --
    
    I am not sure I understand your point. User still could set this 
configuration via SparkConf as we just read its value from SparkConf and set it 
to system properties here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to