Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3841#discussion_r22373048
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1691,15 +1691,12 @@ private[spark] object Utils extends Logging {
/**
* Default maximum number of retries when binding to a port before
giving up.
*/
- val portMaxRetries: Int = {
+ lazy val portMaxRetries: Int = {
--- End diff --
If we just switch this to a `def`, then do we need the system properties
changes, too? Or will just making this a `def` be sufficient? I'm just a bit
wary / skeptical of code that uses system properties because I just spent a
bunch of time cleaning up uses of properties in tests: #3739.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
