Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3607#discussion_r22593506
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala ---
@@ -38,24 +38,30 @@ private[spark] class ClientArguments(args:
Array[String], sparkConf: SparkConf)
var amMemory: Int = 512 // MB
var appName: String = "Spark"
var priority = 0
+ var isClusterMode = false
--- End diff --
this should be the following instead. Otherwise we might forget to set one
but not the other in the future
```
private def isClusterMode: Boolean = userClass != null
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
