Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3607#issuecomment-69041998
Hey @WangTaoTheTonic I believe the latest changes correctly addresses my
last concern (that in client mode the `amMemory` shouldn't depend on
`--driver-memory` at all). However, I believe the better approach is to define
a `var driverMemory` along with the other variables, and set this in
`--driver-memory`. Then later in cluster mode we can set `amMemory =
driverMemory`, but not in client mode. Does that make sense?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
