Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3711#discussion_r22627136
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
    @@ -84,6 +85,14 @@ case class SparkListenerBlockManagerRemoved(time: Long, 
blockManagerId: BlockMan
     @DeveloperApi
     case class SparkListenerUnpersistRDD(rddId: Int) extends SparkListenerEvent
     
    +@DeveloperApi
    +case class SparkListenerExecutorAdded(executorId: String, executorDetails: 
ExecutorDetails)
    +  extends SparkListenerEvent
    +
    +@DeveloperApi
    +case class SparkListenerExecutorRemoved(executorId: String, 
executorDetails: ExecutorDetails)
    --- End diff --
    
    It's just kind of weird that you can't remove an executor without having 
full information about it. I think it's reasonable to expect the caller to 
listen for both the add and remove events.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to