Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/3711#discussion_r22679008
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
---
@@ -160,7 +160,7 @@ class EventLoggingListenerSuite extends FunSuite with
BeforeAndAfter with Loggin
*/
private def testApplicationEventLogging(compressionCodec: Option[String]
= None) {
val conf = getLoggingConf(testDirPath, compressionCodec)
- val sc = new SparkContext("local", "test", conf)
+ val sc = new SparkContext("local-cluster[2,2,512]", "test", conf)
--- End diff --
Instead of making this into an integration test (the `local-cluster` mode
is pretty expensive) could you modify `LocalBackend` to send an executor added
event? Then you can still test with `local` mode, and also there will be less
of an overall difference between the local and the cluster modes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
