Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/3997#discussion_r22838761
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -449,6 +449,16 @@ class SparseVector(
override def toString: String =
"(%s,%s,%s)".format(size, indices.mkString("[", ",", "]"),
values.mkString("[", ",", "]"))
--- End diff --
Yes, the nonzero entries idea did cross my mind. Maybe it's overcautious
that I think it might become a complexity if we want to have another kind of
Vector in the future, which don't have handy internal structure to scan for the
nonzero entries. Again, this can be overcautious.
And the dense == sparse idea looks good, maybe that suits into a util
method better as it would not introduce the existence of `DenseVector` to
`SparseVector` and vice versa.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
