Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/3997#issuecomment-70028461
Agree with @srowen ! @hhbyyh It would be great if you want to re-open this
PR and implement a faster and correct `Vector.equals`. If `sqdist` doesn't
check vector sizes, we should add checks there. It is also nice to add a unit
test in `VectorsSuite` to show it works for two sparse vectors with different
`values` array but equal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
