dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL]
Use ConfigEntry for hardcoded configs in SQL
URL: https://github.com/apache/spark/pull/25059#discussion_r302329029
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -234,6 +234,13 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val IN_MEMORY_TABLE_SCAN_STATISTICS_ENABLED =
+ buildConf("spark.sql.inMemoryTableScanStatistics.enable")
Review comment:
I also did the same mistake. :)
We cannot change the name because this is already used configuration name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
