dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] 
Use ConfigEntry for hardcoded configs in SQL
URL: https://github.com/apache/spark/pull/25059#discussion_r302704340
 
 

 ##########
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/RuntimeConfigSuite.scala
 ##########
 @@ -19,6 +19,7 @@ package org.apache.spark.sql
 
 import org.apache.spark.SparkFunSuite
 import org.apache.spark.internal.config
+import org.apache.spark.sql.internal.{SQLConf, StaticSQLConf}
 
 Review comment:
   ```
   -import org.apache.spark.sql.internal.{SQLConf, StaticSQLConf}
   +import org.apache.spark.sql.internal.SQLConf.CHECKPOINT_LOCATION
   +import 
org.apache.spark.sql.internal.StaticSQLConf.SCHEMA_STRING_LENGTH_THRESHOLD
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to