Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/3518#discussion_r23051282
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -459,7 +459,23 @@ private[spark] class TaskSetManager(
}
// Serialize and return the task
val startTime = clock.getTime()
+
val serializedTask: ByteBuffer = try {
+ // We rely on the DAGScheduler to catch non-serializable
closures and RDDs, so in here
+ // we assume the task can be serialized without exceptions.
+
+ // Check if serialization debugging is enabled
+ val debugSerialization: Boolean = sched.sc.getConf.
+ getBoolean("spark.serializer.debug", false)
+
+ if (debugSerialization) {
+ SerializationHelper.tryToSerialize(ser, task).fold (
--- End diff --
We should make sure this catches any exceptions thrown by the serialization
utility itself and in that case just say that we couldn't produce debugging
output.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
