beliefer commented on a change in pull request #25074: [SPARK-27924][SQL]
Support ANSI SQL Boolean-Predicate syntax
URL: https://github.com/apache/spark/pull/25074#discussion_r308509259
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -840,3 +840,81 @@ case class GreaterThanOrEqual(left: Expression, right:
Expression)
protected override def nullSafeEval(input1: Any, input2: Any): Any =
ordering.gteq(input1, input2)
}
+
+trait BooleanTest extends UnaryExpression with Predicate with
ExpectsInputTypes {
+
+ def boolValue: Boolean
+ def whenNull: Boolean
+
+ override def nullable: Boolean = false
+ override def inputTypes: Seq[DataType] = Seq(BooleanType)
+
+ override def eval(input: InternalRow): Any = {
+ val value = child.eval(input)
+ Option(value) match {
+ case None => whenNull
+ case other => if (whenNull) {
+ value == !boolValue
+ } else {
+ value == boolValue
+ }
+ }
+ }
+
+ override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+ val eval = child.genCode(ctx)
+ ev.copy(code = code"""
+ ${eval.code}
+ ${CodeGenerator.javaType(dataType)} ${ev.value} =
${CodeGenerator.defaultValue(dataType)};
+ if (${eval.isNull}) {
+ ${ev.value} = $whenNull;
+ } else if ($whenNull) {
+ ${ev.value} = ${eval.value} == !$boolValue;
+ } else {
+ ${ev.value} = ${eval.value} == $boolValue;
+ }
+ """, isNull = FalseLiteral)
+ }
+}
+
+case class IsTrue(child: Expression) extends BooleanTest {
+ override def boolValue: Boolean = true
+ override def whenNull: Boolean = false
+ override def sql: String = s"(${child.sql} IS TRUE)"
+}
+
+case class IsNotTrue(child: Expression) extends BooleanTest {
+ override def boolValue: Boolean = true
+ override def whenNull: Boolean = true
+ override def sql: String = s"(${child.sql} IS NOT TRUE)"
+}
+
+case class IsFalse(child: Expression) extends BooleanTest {
+ override def boolValue: Boolean = false
+ override def whenNull: Boolean = false
+ override def sql: String = s"(${child.sql} IS FALSE)"
+}
+
+case class IsNotFalse(child: Expression) extends BooleanTest {
+ override def boolValue: Boolean = false
+ override def whenNull: Boolean = true
+ override def sql: String = s"(${child.sql} IS NOT FALSE)"
+}
+
+object IsUnknown {
+ def apply(child: Expression): Predicate = {
+ new IsNull(child) with ExpectsInputTypes {
+ override def inputTypes: Seq[DataType] = Seq(BooleanType)
Review comment:
@maropu @dongjoon-hyun OK. I will add a test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
