beliefer commented on a change in pull request #25074: [SPARK-27924][SQL]
Support ANSI SQL Boolean-Predicate syntax
URL: https://github.com/apache/spark/pull/25074#discussion_r308529327
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala
##########
@@ -110,6 +110,13 @@ package object dsl {
def isNull: Predicate = IsNull(expr)
def isNotNull: Predicate = IsNotNull(expr)
+ def isTrue: Predicate = IsTrue(expr)
+ def isNotTrue: Predicate = IsNotTrue(expr)
+ def isFalse: Predicate = IsFalse(expr)
+ def isNotFalse: Predicate = IsNotFalse(expr)
+ def isUnknown: Predicate = IsUnknown(expr)
+ def isNotUnknown: Predicate = IsNotUnknown(expr)
Review comment:
> No, @beliefer . You are confused with Scala DSL and SQL.
> This is `sql/catalyst/dsl` which providing Scala API. This is never ANSI
SQL.
> SQL Standard doesn't have `def isNotUnknown`. :)
Thanks for your prompt. I am confused indeed and clear now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
