Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/4109#discussion_r23268078
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -17,7 +17,7 @@
package org.apache.spark.mllib.linalg
-import java.util.{Arrays, Random}
+import java.util.{Arrays => jArrays, Random}
--- End diff --
Any reason to change this? Scala doesn't have `Arrays`. If we want to
emphasize this is from Java, we can do `import java.{util => ju}` and use
`ju.Arrays` in the code. This is recommended by @srowen
Anyway, it is strange to have a class name alias start with a lowercase
letter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
