Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/4109#discussion_r23268073
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -317,19 +317,23 @@ private[spark] object BLAS extends Serializable with
Logging {
B: DenseMatrix,
beta: Double,
C: DenseMatrix): Unit = {
+ val transModA = transA ^ A.isTransposed
--- End diff --
If we set the transpose flag in matrix, maybe we should remove the `transA`
and `transB` arguments from the BLAS interface: `gemm(alpha, A, B, beta, C)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
