voidbag commented on a change in pull request #24779: [SPARK-27929][SQL] Make
percentile function receive frq of double
URL: https://github.com/apache/spark/pull/24779#discussion_r313522778
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
##########
@@ -67,16 +67,23 @@ case class Percentile(
child: Expression,
percentageExpression: Expression,
frequencyExpression : Expression,
+ isIntFreqExpression: Expression,
Review comment:
@srowen
If the data had only discrete frequencies, your suggestion would be enough
(0.75 -> 75)
But, the suggestion isn't enough for fractional number like water with 1/3 L.
1/3 frequency cannot be converted to integer. So existing api cannot receive
the fractional frequency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
