voidbag commented on a change in pull request #24779: [SPARK-27929][SQL] Make percentile function receive frq of double URL: https://github.com/apache/spark/pull/24779#discussion_r313570118
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala ########## @@ -67,16 +67,23 @@ case class Percentile( child: Expression, percentageExpression: Expression, frequencyExpression : Expression, + isIntFreqExpression: Expression, Review comment: You are right. The logics are different. So the additional parameter is for logic switching. I thought the interpolation of value was based on the assumption that weight is integer, which cannot be implemented with floating number. But I can't remember the reason exactly. I'll put concrete example. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org