rdblue commented on a change in pull request #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#discussion_r315819485
########## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala ########## @@ -347,9 +346,16 @@ class DataSourceV2SQLSuite extends QueryTest with SharedSparkSession with Before test("ReplaceTableAsSelect: CREATE OR REPLACE new table has same behavior as CTAS.") { Seq("testcat", "testcat_atomic").foreach { catalogName => - spark.sql(s"CREATE TABLE $catalogName.created USING $orc2 AS SELECT id, data FROM source") spark.sql( - s"CREATE OR REPLACE TABLE $catalogName.replaced USING $orc2 AS SELECT id, data FROM source") + s""" + |CREATE TABLE $catalogName.created USING $v2Format + |AS SELECT id, data FROM source + """.stripMargin) + spark.sql( + s""" + |CREATE TABLE $catalogName.replaced USING $v2Format Review comment: This changed the SQL. The original query was `CREATE OR REPLACE`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org