gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316134867
########## File path: sql/core/pom.xml ########## @@ -147,6 +147,12 @@ <artifactId>mockito-core</artifactId> <scope>test</scope> </dependency> + <!-- RocksDB dependency for Structured Streaming State Store --> + <dependency> + <groupId>org.rocksdb</groupId> + <artifactId>rocksdbjni</artifactId> + <version>${rocksdb.version}</version> Review comment: I think this should be added to the root pom's `dependencyManagement` and then no version has to be provided on all other places (like here). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org