Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4208#discussion_r23553132
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
    @@ -18,8 +18,9 @@
     package org.apache.spark
     
     import scala.collection.JavaConverters._
    --- End diff --
    
    Sorry for the demand, but can we remove this implicit conversion? I'm 
worried this coupled with the concurrent map will make this file more prone to 
bugs in future development. Also because this adds a bunch of methods that are 
not as clear as the Java methods (like contains in the Scala version of the 
Map). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to