Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4208#discussion_r23553383
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -47,12 +48,12 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging {
/** Create a SparkConf that loads defaults from system properties and
the classpath */
def this() = this(true)
- private[spark] val settings = new TrieMap[String, String]()
+ private[spark] val settings = new ConcurrentHashMap[String, String]()
--- End diff --
while you are at it, define the return type explicitly here
(java.util.Map?) since it is public type
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
