MaxGekk commented on a change in pull request #25708: [SPARK-28141][SQL]
Support special date values
URL: https://github.com/apache/spark/pull/25708#discussion_r321694503
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -564,4 +567,17 @@ class DateTimeUtilsSuite extends SparkFunSuite {
assert(DateTimeUtils.toMillis(-9223372036844776001L) ===
-9223372036844777L)
assert(DateTimeUtils.toMillis(-157700927876544L) === -157700927877L)
}
+
+ test("special date values") {
+ DateTimeTestUtils.outstandingTimezonesIds.foreach { timeZone =>
+ val zoneId = getZoneId(timeZone)
+
+ assert(toDate("epoch", zoneId).get === 0)
+ val today = localDateToDays(LocalDate.now(zoneId))
+ assert(toDate("yesterday", zoneId).get === today - 1)
Review comment:
Here, there is the risk that `today` contains previous days if we were
unlucky and the test was executed at the end of the day. Need to introduce some
tolerance, I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
