MaxGekk commented on a change in pull request #25708: [SPARK-28141][SQL] Support special date values URL: https://github.com/apache/spark/pull/25708#discussion_r322018260
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala ########## @@ -81,7 +81,10 @@ private[sql] class JacksonGenerator( options.timestampFormat, options.zoneId, options.locale) - private val dateFormatter = DateFormatter(options.dateFormat, options.locale) + private val dateFormatter = DateFormatter( + options.dateFormat, + options.zoneId, + options.locale) Review comment: Added tests for `from_json` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org