Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3658#discussion_r23566689
  
    --- Diff: core/pom.xml ---
    @@ -408,6 +372,20 @@
               </execution>
             </executions>
           </plugin>
    +      <plugin>
    +        <groupId>org.apache.maven.plugins</groupId>
    +        <artifactId>maven-shade-plugin</artifactId>
    +        <configuration>
    +          <shadedArtifactAttached>false</shadedArtifactAttached>
    +          <artifactSet>
    +            <includes>
    +              <include>com.google.guava:guava</include>
    +              
<include>org.apache.spark:spark-network-common_${scala.binary.version}</include>
    +              
<include>org.apache.spark:spark-network-shuffle_${scala.binary.version}</include>
    --- End diff --
    
    Yes. From the first comment:
    
    > For this reason, also, the network/ dependencies are shaded into the 
spark-core artifact too, so that the raw Guava dependency doesn't leak.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to