Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3658#issuecomment-71544279
Hey so a couple questions about this. This does make things simpler overall
in terms of the build. Some higher level questions:
1. This adds 1,500 class files and about 2 MB or a 30% in file size to the
Spark core jar. Does this suggest any limits on how many overall dependencies
we can shade in Spark longer term (i.e. in addition to guava)?
2. Inlining two of our own sub-projects into the spark-core jar seems a bit
strange. Why not just have the shaded guava in the little assembly jar we
create for YARN? Is there a reason we _must_ use the guava dependency that is
provided on the cluster? If we did take the current approach, does this mean
that Spark core as advertised in maven central won't depend on Spark's network
modules... would we still publish the network modules then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
