Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3798#issuecomment-71556595
@koeninger do you mind going through the changes for a pass to fix style
violations? Our style checker isn't entirely automated yet.
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
In particular, there are a few things:
1. Use JavaDoc style, not ScalaDoc.
2. Indent function parameter definitions with 4 spaces, not 2.
In addition, you probably want to go through the file to tighten visibility
of various methods, and reduce the number of things exposed. Historically,
certain parts of Spark have not done a good job with visibility tightening and
that has always come back to bite us.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
