Github user koeninger commented on the pull request:
https://github.com/apache/spark/pull/3798#issuecomment-71564796
I'm not a big fan of either either :)
The issue here is that KafkaCluster is potentially dealing with multiple
exceptions due to multiple brokers. As a user of library code, I'd
potentially want access to all of the exceptions, not just the first or
last one.
It sounds like TD is leaning towards not making KafkaCluster exposed, in
which case we can do whatever makes sense for the internal usage of it.
On Mon, Jan 26, 2015 at 5:03 PM, Reynold Xin <notificati...@github.com>
wrote:
> BTW one other thing - Either is really dangerous and very complicated to
> use. It almost always leads to downstream code becoming a mess.
>
> You are mostly just using it for exception propagation. Why not just throw
> exceptions?
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/3798#issuecomment-71557370>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
