srowen commented on a change in pull request #25770: [SPARK-29064][CORE] Add
PrometheusResource to export Executor metrics
URL: https://github.com/apache/spark/pull/25770#discussion_r323752067
##########
File path: core/src/main/scala/org/apache/spark/ui/SparkUI.scala
##########
@@ -66,6 +66,7 @@ private[spark] class SparkUI private (
addStaticHandler(SparkUI.STATIC_RESOURCE_DIR)
attachHandler(createRedirectHandler("/", "/jobs/", basePath = basePath))
attachHandler(ApiRootResource.getServletHandler(this))
+ attachHandler(PrometheusResource.getServletHandler(this))
Review comment:
Should this be more optional, like only attached if one configures something
to use Prometheus?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
