xuanyuanking commented on a change in pull request #25620: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/25620#discussion_r324503207
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -1531,9 +1540,9 @@ private[spark] class DAGScheduler(
// Mark all the map as broken in the map stage, to ensure retry
all the tasks on
// resubmitted stage attempt.
mapOutputTracker.unregisterAllMapOutput(shuffleId)
- } else if (mapId != -1) {
+ } else if (mapIndex != -1) {
// Mark the map whose fetch failed as broken in the map stage
- mapOutputTracker.unregisterMapOutput(shuffleId, mapId, bmAddress)
+ mapOutputTracker.unregisterMapOutput(shuffleId, mapIndex,
bmAddress)
}
Review comment:
Great thanks for this comment, it's my mistake to use -1 as the default
value of map index for old fetch protocol.
The logic of `mapId == -1` should only for `MetadataFetchFailedException`,
it involoved in
https://github.com/apache/spark/commit/7d71b9a56a4d644ccabb56dd282e84e2a49ef144
and #1227.
For our logic, just pass map index for both old and new protocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
