xuanyuanking commented on a change in pull request #25620: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/25620#discussion_r324669831
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -1105,7 +1105,16 @@ private[spark] class DAGScheduler(
private def submitMissingTasks(stage: Stage, jobId: Int) {
logDebug("submitMissingTasks(" + stage + ")")
- // First figure out the indexes of partition ids to compute.
+ // Before find missing partition, do the intermediate state clean work
first.
+ // The operation here can make sure for the intermediate stage,
`findMissingPartitions()`
+ // returns all partitions every time.
+ stage match {
Review comment:
Thanks for the detailed comment.
I tried to combine both at first but seems kind of duplicated code.
For the concerned about no missing partitions stage submission, I
checked`shuffleMapStage.isAvailable` for the unregister in aa3a409, what we
need here is making sure the partially completed indeterminate stage will be
whole stage rerun.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
