Github user zapletal-martin commented on the pull request:
https://github.com/apache/spark/pull/3519#issuecomment-71986438
@mengxr thanks for very valuable feedback!
Can you please clarify your high-level comment 1)? It is true that by
flipping the sign the algorithm can be applied to calculate the antitonic case.
But would you like to see `isotonic` removed just from the algorithm or also
from the public api? If the former I am not sure if that would actually
simplify the algorithm, because the sign would have to be flipped twice making
it a bit more intricate to understand. The latter would potentially make it a
bit more difficult to use for a user for the antitonic case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
