Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/3519#issuecomment-71993519
I suggest removing it just from the implementation. It would make the
`PAVA` implementation cleaner without isotonic/antitonic switch. The `run`
method should look at this
~~~
if (isotonic) {
val (boundaries, predictions) = PAVA.train(rdd)
} else {
val (boundaries, predictions) = PAVA.train(rdd.map(x => (-x._1, x._2,
x._3)))
// flip boundaries
}
~~~
I didn't think about the correctness throughly. But if this is a correct,
it looks simpler, at least for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
