HeartSaVioR commented on a change in pull request #25943:
[WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for
(SQL)AppStatusListener
URL: https://github.com/apache/spark/pull/25943#discussion_r331419044
##########
File path: core/src/main/scala/org/apache/spark/storage/StorageLevel.scala
##########
@@ -163,6 +163,20 @@ object StorageLevel {
val MEMORY_AND_DISK_SER_2 = new StorageLevel(true, true, false, false, 2)
val OFF_HEAP = new StorageLevel(true, true, true, false, 1)
+ /**
+ * :: DeveloperApi ::
+ * Return the StorageLevel object with the specified description.
+ */
+ @DeveloperApi
+ def fromDescription(desc: String): StorageLevel = {
Review comment:
I'm a bit worried that we're relying on string parse which is easy to be
broken. Is this covered by UT or so?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
