HeartSaVioR commented on a change in pull request #25943:
[WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for
(SQL)AppStatusListener
URL: https://github.com/apache/spark/pull/25943#discussion_r331411900
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala
##########
@@ -328,7 +340,18 @@ class SQLAppStatusListener(
}.toSet
stageMetrics.keySet().asScala
.filter(!activeStages.contains(_))
- .foreach(stageMetrics.remove)
+ .foreach { stageId =>
+ stageMetrics.remove(stageId)
+ if (live) {
Review comment:
Is this new requirement, or existing bug? If that's an existing bug, it
would be nice to separate both cases and deal with other (small) PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
