HeartSaVioR commented on a change in pull request #25943:
[WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for
(SQL)AppStatusListener
URL: https://github.com/apache/spark/pull/25943#discussion_r332310268
##########
File path: core/src/main/scala/org/apache/spark/status/LiveEntity.scala
##########
@@ -370,6 +374,8 @@ private class LiveStage extends LiveEntity {
var completedTasks = 0
var failedTasks = 0
val completedIndices = new OpenHashSet[Int]()
+ // will only be set when recover LiveStage is needed.
Review comment:
same here: Could we add `completedIndices` into new KVStore entity class,
and restore LiveStage from both StageDataWrapper and new class? Adding it to
the `StageDataWrapper` is also fine for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
