HeartSaVioR commented on a change in pull request #25943:
[WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for
(SQL)AppStatusListener
URL: https://github.com/apache/spark/pull/25943#discussion_r332300316
##########
File path: core/src/main/scala/org/apache/spark/status/LiveEntity.scala
##########
@@ -59,21 +59,23 @@ private[spark] abstract class LiveEntity {
}
-private class LiveJob(
+private[spark] class LiveJob(
val jobId: Int,
- name: String,
+ val name: String,
val submissionTime: Option[Date],
val stageIds: Seq[Int],
- jobGroup: Option[String],
- numTasks: Int,
- sqlExecutionId: Option[Long]) extends LiveEntity {
+ val jobGroup: Option[String],
+ val numTasks: Int,
+ val sqlExecutionId: Option[Long]) extends LiveEntity {
var activeTasks = 0
var completedTasks = 0
var failedTasks = 0
// Holds both the stage ID and the task index, packed into a single long
value.
val completedIndices = new OpenHashSet[Long]()
+ // will only be set when recover LiveJob is needed.
Review comment:
I don't mind adding these to JobDataWrapper as well - it could bring
problems on backward compatibility though. It sounds me as tradeoff between
"possibly inaccurate" vs "no backward compatibility".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
