dilipbiswal commented on a change in pull request #26042: [SPARK-29092][SQL] 
Report additional information about DataSourceScanExec in EXPLAIN FORMATTED
URL: https://github.com/apache/spark/pull/26042#discussion_r335274734
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
 ##########
 @@ -436,6 +436,9 @@ class SQLQueryTestSuite extends QueryTest with 
SharedSparkSession {
       .replaceAll(
         s"Location.*/sql/core/spark-warehouse/$clsName/",
         s"Location ${notIncludedMsg}sql/core/spark-warehouse/")
+      .replaceAll(
+        s"Location.*\\.\\.\\.",
 
 Review comment:
   @cloud-fan Actually i had thought about it. But for some tests, i wasn't 
sure if we should change the output. For example : 
   
```sql/core/src/test/resources/sql-tests/results/describe-part-after-analyze.sql```
   
   the test is : 
   DESC EXTENDED t PARTITION (ds='2017-08-01', hr=10)
   
   Perhaps displaying the location is the intention. What do you think ?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to