dilipbiswal commented on a change in pull request #26042: [SPARK-29092][SQL]
Report additional information about DataSourceScanExec in EXPLAIN FORMATTED
URL: https://github.com/apache/spark/pull/26042#discussion_r335811628
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -436,6 +436,9 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
.replaceAll(
s"Location.*/sql/core/spark-warehouse/$clsName/",
s"Location ${notIncludedMsg}sql/core/spark-warehouse/")
+ .replaceAll(
+ s"Location.*\\.\\.\\.",
Review comment:
> How about we don't truncate the location in the new explain?
Running `test("explain formatted - check presence of subquery in case of
DPP") ` in ExplainSuite
Wenchen, i am afraid, the location can be arbitrarily large like following.
Are we sure we want to show everything ? It may make the plan un-readable again
?
```
PrunedInMemoryFileIndex[file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-
warehouse/org.apache.spark.sql.ExplainSuite/df1/k=193,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-
warehouse/org.apache.spark.sql.ExplainSuite/df1/k=546,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-
warehouse/org.apache.spark.sql.ExplainSuite/df1/k=0,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-
warehouse/org.apache.spark.sql.ExplainSuite/df1/k=27,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-
warehouse/org.apache.spark.sql.ExplainSuite/df1/k=572,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=333,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-
warehouse/org.apache.spark.sql.ExplainSuite/df1/k=451,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-
warehouse/org.apache.spark.sql.ExplainSuite/df1/k=56,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-
warehouse/org.apache.spark.sql.ExplainSuite/df1/k=55,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-
warehouse/org.apache.spark.sql.ExplainSuite/df1/k=628,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=937,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=609,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=37,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=7,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=908,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=34,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=621,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=596,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=108,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=42,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=990,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=294,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=418,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=749,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-warehouse/org.apache.spark.sql.ExplainSuite/df1/k=606,
file:/Users/dilipbiswal/mygit/apache/spark/sql/core/spark-
....
....
....
.....
.....
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
