cloud-fan commented on a change in pull request #26053: [SPARK-29379][SQL]SHOW
FUNCTIONS show '!=', '<>' , 'between', 'case'
URL: https://github.com/apache/spark/pull/26053#discussion_r335327656
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
##########
@@ -73,6 +73,11 @@ case class CreateFunctionCommand(
s"is not allowed: '${databaseName.get}'")
}
+ // Redefine a virtual function is not allowed
+ if
(FunctionsCommand.virtualOperators.contains(functionName.toLowerCase(Locale.ROOT)))
{
+ throw new AnalysisException(s"It's not allowed to redefine virtual
function '$functionName'")
Review comment:
If we can't fix the problem completely here, let's keep it unchanged and fix
them all together later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
