cloud-fan commented on a change in pull request #26053: [SPARK-29379][SQL]SHOW
FUNCTIONS show '!=', '<>' , 'between', 'case'
URL: https://github.com/apache/spark/pull/26053#discussion_r335447140
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
##########
@@ -170,6 +171,11 @@ case class DropFunctionCommand(
override def run(sparkSession: SparkSession): Seq[Row] = {
val catalog = sparkSession.sessionState.catalog
+
+ if
(FunctionsCommand.virtualOperators.contains(functionName.toLowerCase(Locale.ROOT)))
{
+ throw new AnalysisException(s"Cannot drop virtual function
'$functionName'")
Review comment:
ditto, we should make sure the behavior is consistent with other operators.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
