cloud-fan commented on a change in pull request #26712: [SPARK-29883][SQL]
Improve error messages when function name is an alias
URL: https://github.com/apache/spark/pull/26712#discussion_r352410699
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
##########
@@ -286,6 +286,15 @@ abstract class Expression extends TreeNode[Expression] {
override def simpleStringWithNodeId(): String = {
throw new UnsupportedOperationException(s"$nodeName does not implement
simpleStringWithNodeId")
}
+
+ var functionAlias: String = ""
Review comment:
It's a bad practice to make the `Expression` mutable for trivial things like
this. How about using `RuntimeReplaceable`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
