cloud-fan commented on a change in pull request #26763: [SPARK-30125][SQL]
Remove PostgreSQL dialect
URL: https://github.com/apache/spark/pull/26763#discussion_r354297985
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -52,9 +52,9 @@ grammar SqlBase;
}
/**
- * When true, the behavior of keywords follows ANSI SQL standard.
+ * When true, ANSI SQL parsing mode is enabled.
*/
- public boolean SQL_standard_keyword_behavior = false;
Review comment:
I think `SQL_standard_keyword_behavior` is better. Can we keep it? ANSI is
too vague here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
