cloud-fan commented on a change in pull request #26763: [SPARK-30125][SQL] 
Remove PostgreSQL dialect
URL: https://github.com/apache/spark/pull/26763#discussion_r355483703
 
 

 ##########
 File path: docs/sql-keywords.md
 ##########
 @@ -19,7 +19,7 @@ license: |
   limitations under the License.
 ---
 
-When `spark.sql.dialect=PostgreSQL` or keep default `spark.sql.dialect=Spark` 
with setting `spark.sql.dialect.spark.ansi.enabled` to true, Spark SQL will use 
the ANSI mode parser.
+When `spark.sql.dialect.spark.ansi.enabled` is true, Spark SQL will use the 
ANSI mode parser.
 
 Review comment:
   I don't think we can do a clean revert, we need to check the diff of this PR 
and see if they make sense.
   
   Here we should use `spark.sql.ansi.enabled`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to