cloud-fan commented on a change in pull request #26763: [SPARK-30125][SQL]
Remove PostgreSQL dialect
URL: https://github.com/apache/spark/pull/26763#discussion_r355490037
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/int2.sql
##########
@@ -92,9 +92,11 @@ WHERE f1 > -32767;
SELECT '' AS five, i.f1, i.f1 - int('2') AS x FROM INT2_TBL i;
-SELECT '' AS five, i.f1, i.f1 / smallint('2') AS x FROM INT2_TBL i;
+-- PostgreSQL `/` is the same with Spark `div` since SPARK-2659.
+SELECT '' AS five, i.f1, i.f1 div smallint('2') AS x FROM INT2_TBL i;
Review comment:
let's keep the tests the same as pgsql. we should still use `/`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
